chore: Update argocd, k8s & kustomize deps #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhesh Ghadi <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
svghadi
commented
Nov 8, 2024
| "strings" | ||
|
|
||
| "github.com/go-git/go-git/v5" | ||
| "github.com/go-git/go-git/v5/plumbing/object" | ||
| "github.com/go-git/go-git/v5/plumbing/storer" | ||
| "github.com/go-git/go-git/v5/storage/memory" | ||
| "sigs.k8s.io/kustomize/pkg/fs" | ||
| fs "sigs.k8s.io/kustomize/kyaml/filesys" |
There was a problem hiding this comment.
sigs.k8s.io/kustomize/pkg/fs package is deprecated in favour of sigs.k8s.io/kustomize/kyaml/filesys
Comment on lines
-27
to
-42
| k8sfactory := k8sdeps.NewFactory() | ||
| ldr, err := loader.NewLoader(path, files) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer func() { | ||
| err = ldr.Cleanup() | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| }() | ||
| kt, err := target.NewKustTarget(ldr, k8sfactory.ResmapF, k8sfactory.TransformerF) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| r, err := kt.MakeCustomizedResMap() |
There was a problem hiding this comment.
Latest kustomize provides a wrapper krusty which has simplified functions to run kustomize build and return resources.
ref:
Signed-off-by: Siddhesh Ghadi <[email protected]>
svghadi
changed the title
svghadi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it:
Update Argo CD, K8s & kustomize dep to latest
Changes
Note
Kustomize has changed a lot over the years with breaking and API changes. I am not familiar with backend codebase or its functionalities. It would be good if someone familiar with backend reviews the kustomize related changes. Additionally, some manual testing of the functionalities would be great if possible.